Cherry pick PR #3205 into release/v1.0 branch.#4143
Merged
martinmr merged 1 commit intorelease/v1.0from Oct 14, 2019
Merged
Conversation
This fixes #3807.
![hackerone-code[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@martinmr you can click here to see the review status or cancel the code review job.
| } | ||
|
|
||
| if sg.DestUIDs == nil || len(sg.DestUIDs.Uids) == 0 { | ||
| // Looks like we're done here. Be careful with nil srcUIDs! |
There was a problem hiding this comment.
We should add more context to this comment. Why should we be careful with srcUIDs == nil? We don't use it here either.
| } | ||
| out = append(out, child) | ||
| } | ||
| sg.Children = out // Remove any expand nodes we might have added. |
There was a problem hiding this comment.
Comment should be on top of the for loop, since its describing the for loop process.
manishrjain
approved these changes
Oct 14, 2019
Contributor
manishrjain
left a comment
manishrjain
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @danielmai and @martinmr)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #3807.
This change is