flag to turn on/off sending Sentry events. default on. Fixed #1198 (#5156)#5169
Merged
parasssh merged 2 commits intorelease/v20.03from Apr 10, 2020
Merged
flag to turn on/off sending Sentry events. default on. Fixed #1198 (#5156)#5169parasssh merged 2 commits intorelease/v20.03from
parasssh merged 2 commits intorelease/v20.03from
Conversation
martinmr
approved these changes
Apr 10, 2020
Contributor
martinmr
left a comment
martinmr
left a comment
There was a problem hiding this comment.
A couple minor comments but it
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @manishrjain and @parasssh)
dgraph/cmd/alpha/run.go, line 151 at r1 (raw file):
o Sentry. (default on)"
minor: Put the period at the end "Sentry (default on)."
dgraph/cmd/zero/run.go, line 93 at r1 (raw file):
flag.Duration("rebalance_interval", 8*time.Minute, "Interval for trying a predicate move.") flag.Bool("telemetry", true, "Send anonymous telemetry data to Dgraph devs.") flag.Bool("enable_sentry", true, "Turn on/off sending events to Sentry. (default on)")
minor: Put the period at the end "Sentry (default on)."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-picked from commit b5d6b09
This change is
Docs Preview: