release/v1.2: Alpha: Enable bloom filter caching (#5552)#5554
Merged
jarifibrahim merged 1 commit intorelease/v1.2from Jun 8, 2020
Merged
release/v1.2: Alpha: Enable bloom filter caching (#5552)#5554jarifibrahim merged 1 commit intorelease/v1.2from
jarifibrahim merged 1 commit intorelease/v1.2from
Conversation
Badger supports the caching of SST bloom filters. This PR enables caching bloom filters in ristretto. The bloom filter cache is enabled only for the p directory. The bloom filters for the w directory will be kept in memory. We can add caching for it later if necessary. This PR also removes old stale todos. (cherry picked from commit 92328a7)
jarifibrahim
changed the title
pawanrawal
approved these changes
Jun 8, 2020
Contributor
pawanrawal
left a comment
pawanrawal
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Badger supports the caching of SST bloom filters. This PR enables
caching bloom filters in ristretto. The bloom filter cache is enabled
only for the p directory. The bloom filters for the w directory will be
kept in memory. We can add caching for it later if necessary.
This PR also removes old stale todos.
(cherry picked from commit 92328a7)
This change is
Docs Preview: