fix(live): fix usage of force-namespace parameter in live loader#7526
Merged
NamanJain8 merged 1 commit intomasterfrom Mar 8, 2021
Merged
fix(live): fix usage of force-namespace parameter in live loader#7526NamanJain8 merged 1 commit intomasterfrom
NamanJain8 merged 1 commit intomasterfrom
Conversation
github-actions
Bot
added
area/live-loader
NamanJain8
changed the title
ahsanbarkati
approved these changes
Mar 8, 2021
aman-bansal
pushed a commit
that referenced
this pull request
Mar 9, 2021
This PR fixes the behaviour of --force-namespace flag in live loader. Earlier, we used to silently ignore this flag when passed by the non-galaxy user. Now, we throw an error if the force-namespace flag is used by the non-galaxy user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the behaviour of
--force-namespaceflag in live loader.Earlier, we used to silently ignore this flag when passed by the non-galaxy user. Now, we throw an error if the force-namespace flag is used by the non-galaxy user.
This change is