Skip to content

Conversation

@sidnt
Copy link
Contributor

@sidnt sidnt commented Feb 19, 2021

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Feb 19, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@abhimanyusinghgaur abhimanyusinghgaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to sign the CLA and address the review comments, then I can merge it.

Thanks for improving the docs!

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sidnt)


README.md, line 334 at r1 (raw file):

Quoted 4 lines of code…
Response mutationResponse = txn.mutate(mu);
// mutationResponse stores a Response protocol buffer object
// eg to get the key created in this mutation
System.out.println(mutationResponse.getUids)

It looks good this way:

// mutationResponse stores a Response protocol buffer object
Response mutationResponse = txn.mutate(mu);
// eg: to get the UIDs created in this mutation
System.out.println(mutationResponse.getUidsMap())

using mutationResponse.getUidsMap() instead of mutationResponse.getUids() as the latter is deprecated.

Copy link
Contributor

@abhimanyusinghgaur abhimanyusinghgaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sidnt)

@abhimanyusinghgaur abhimanyusinghgaur merged commit f89ebed into hypermodeinc:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants