Skip to content

Conversation

@ravisingal
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #86 (c131f25) into main (45b88ce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #86   +/-   ##
=========================================
  Coverage     80.71%   80.71%           
  Complexity      222      222           
=========================================
  Files            27       27           
  Lines           752      752           
  Branches         56       56           
=========================================
  Hits            607      607           
  Misses           98       98           
  Partials         47       47           
Flag Coverage Δ Complexity Δ
integration 80.71% <ø> (ø) 0.00 <ø> (ø)
unit 67.77% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45b88ce...c131f25. Read the comment docs.

@github-actions

This comment has been minimized.

@JBAhire
Copy link
Member

JBAhire commented Apr 8, 2021

@aaron-steinfeld , it didn't ask for review from ci-owners ?

@aaron-steinfeld
Copy link
Contributor

@aaron-steinfeld , it didn't ask for review from ci-owners ?

I tried giving them read permissions to the repo (since members should be deriving their permissions from other ways) but I'm guessing that didn't work. I just bumped it to write. let me try cycling the PR and see if they come on.

@aaron-steinfeld aaron-steinfeld requested a review from a team April 8, 2021 13:22
@aaron-steinfeld
Copy link
Contributor

They didn't automatically, but it may be because it already had an approval from you. I manually added and they do have the little shield, so hopefully that was it.

@github-actions

This comment has been minimized.

@ravisingal ravisingal merged commit 75a3915 into main Apr 9, 2021
@ravisingal ravisingal deleted the publish-ht-artifactory branch April 9, 2021 05:54
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2021

Unit Test Results

20 files  ±0  20 suites  ±0   11s ⏱️ ±0s
75 tests ±0  75 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 75a3915. ± Comparison against base commit 45b88ce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants