test: simplify tests #290
Merged
test: simplify tests #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-steinfeld
commented
Apr 23, 2025
|
|
||
| @BeforeEach() | ||
| private Collection collection; | ||
| @Mock private Clock mockClock; |
Contributor
Author
There was a problem hiding this comment.
So I added the mockito extension just as a best practice, it's not directly related to the change. But it does lend readability as we need less setup and it will fail if we start mocking things that the test path doesn't touch (you can see some unused mocks I removed in WriteConfigForUpdateWithUpsertCondition)
| Pagination.getDefaultInstance(), | ||
| emptyList()); | ||
|
|
||
| verify(collection) |
Contributor
Author
There was a problem hiding this comment.
This is what I was suggesting in the other PR - arg captors aren't needed, just call the public API and verify that the query looks like you want it to.
| } | ||
| } | ||
|
|
||
| public static class MockDatastore implements Datastore { |
Contributor
Author
There was a problem hiding this comment.
This was overkill, a regular mockito mock can do this more simply.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.