Skip to content

chore: Add EXISTS and NOT_EXISTS to relational operators #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 4, 2025
Merged

chore: Add EXISTS and NOT_EXISTS to relational operators #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
52e1f2d
Added exists and not exists to relational operators
rutvij-menavlikar Jul 31, 2025
a042603
Suppress dependency failure
rutvij-menavlikar Aug 4, 2025
32e6e14
Added filter conversion and unit test
rutvij-menavlikar Aug 4, 2025
7bf5953
Remove suppression
rutvij-menavlikar Aug 4, 2025
63185dd
Merge branch 'main' into rutvij/inspector-fix
sanket-mundra Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config-service-api/src/main/proto/org/hypertrace/config/service/v1/config_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,8 @@ enum RelationalOperator {
RELATIONAL_OPERATOR_LT = 6;
RELATIONAL_OPERATOR_GTE = 7;
RELATIONAL_OPERATOR_LTE = 8;
RELATIONAL_OPERATOR_EXISTS = 9;
RELATIONAL_OPERATOR_NOT_EXISTS = 10;
}

enum LogicalOperator {
Expand Down
8 changes: 8 additions & 0 deletions config-service-impl/src/main/java/org/hypertrace/config/service/store/FilterBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,14 @@ private Filter evaluateLeafExpression(RelationalFilter relationalFilter) {
case RELATIONAL_OPERATOR_GTE:
return new Filter(
Filter.Op.GTE, buildConfigFieldPath(relationalFilter.getConfigJsonPath()), value);
case RELATIONAL_OPERATOR_EXISTS:
return new Filter(
Filter.Op.EXISTS, buildConfigFieldPath(relationalFilter.getConfigJsonPath()), value);
case RELATIONAL_OPERATOR_NOT_EXISTS:
return new Filter(
Filter.Op.NOT_EXISTS,
buildConfigFieldPath(relationalFilter.getConfigJsonPath()),
value);
case UNRECOGNIZED:
default:
throw Status.INVALID_ARGUMENT
Expand Down
6 changes: 6 additions & 0 deletions ...rvice-impl/src/main/java/org/hypertrace/config/service/store/FilterExpressionBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,12 @@ private FilterTypeExpression buildRelationalExpression(RelationalFilter relation
case RELATIONAL_OPERATOR_GTE:
operator = RelationalOperator.GTE;
break;
case RELATIONAL_OPERATOR_EXISTS:
operator = RelationalOperator.EXISTS;
break;
case RELATIONAL_OPERATOR_NOT_EXISTS:
operator = RelationalOperator.NOT_EXISTS;
break;
case UNRECOGNIZED:
default:
throw Status.INVALID_ARGUMENT
Expand Down
35 changes: 35 additions & 0 deletions config-service-impl/src/test/java/org/hypertrace/config/service/store/FilterBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,41 @@ void buildDocStoreFilter2() {
assertEquals(docFilter.toString(), filterBuilder.buildDocStoreFilter(filter).toString());
}

@Test
void testExistsAndNotExistsOperators() {
// Test EXISTS operator
Filter existsFilter =
Filter.newBuilder()
.setRelationalFilter(
RelationalFilter.newBuilder()
.setConfigJsonPath("testField")
.setOperator(RelationalOperator.RELATIONAL_OPERATOR_EXISTS))
.build();

org.hypertrace.core.documentstore.Filter expectedExistsFilter =
new org.hypertrace.core.documentstore.Filter(
org.hypertrace.core.documentstore.Filter.Op.EXISTS, "config.testField", null);
assertEquals(
expectedExistsFilter.toString(),
filterBuilder.buildDocStoreFilter(existsFilter).toString());

// Test NOT_EXISTS operator
Filter notExistsFilter =
Filter.newBuilder()
.setRelationalFilter(
RelationalFilter.newBuilder()
.setConfigJsonPath("anotherField")
.setOperator(RelationalOperator.RELATIONAL_OPERATOR_NOT_EXISTS))
.build();

org.hypertrace.core.documentstore.Filter expectedNotExistsFilter =
new org.hypertrace.core.documentstore.Filter(
org.hypertrace.core.documentstore.Filter.Op.NOT_EXISTS, "config.anotherField", null);
assertEquals(
expectedNotExistsFilter.toString(),
filterBuilder.buildDocStoreFilter(notExistsFilter).toString());
}

@Test
void buildDocStoreFilter3() {
Filter filter =
Expand Down
Loading