Skip to content

ENGTAI-65811: Adding channel config protos and validation for Google Secops Integration #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025
Merged

ENGTAI-65811: Adding channel config protos and validation for Google Secops Integration #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdb2d78
Adding channel config protos and validation for Google Secops Integra…
Kunal-8789 Aug 11, 2025
7de4aae
Merge branch 'main' into ENGTAI-65811
Kunal-8789 Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...i/src/main/proto/org/hypertrace/notification/config/service/v1/notification_channel.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ message NotificationChannelMutableData {
repeated SplunkIntegrationChannelConfig splunk_integration_channel_config = 5;
repeated SyslogIntegrationChannelConfig syslog_integration_channel_config = 6;
repeated HttpEventCollectorChannelConfig http_event_collector_channel_config = 7;
repeated GoogleSecopsIntegrationChannelConfig google_secops_integration_channel_config = 8;
}

message GoogleSecopsIntegrationChannelConfig {
string google_secops_integration_id = 1;
}

message HttpEventCollectorChannelConfig {
Expand Down
13 changes: 12 additions & 1 deletion ...ertrace/notification/config/service/NotificationChannelConfigServiceRequestValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import org.hypertrace.notification.config.service.v1.EmailChannelConfig;
import org.hypertrace.notification.config.service.v1.GetAllNotificationChannelsRequest;
import org.hypertrace.notification.config.service.v1.GetNotificationChannelRequest;
import org.hypertrace.notification.config.service.v1.GoogleSecopsIntegrationChannelConfig;
import org.hypertrace.notification.config.service.v1.HttpEventCollectorChannelConfig;
import org.hypertrace.notification.config.service.v1.NotificationChannel;
import org.hypertrace.notification.config.service.v1.NotificationChannelMutableData;
Expand Down Expand Up @@ -131,7 +132,8 @@ private void validateNotificationChannelMutableData(NotificationChannelMutableDa
&& data.getS3BucketChannelConfigCount() == 0
&& data.getSplunkIntegrationChannelConfigCount() == 0
&& data.getSyslogIntegrationChannelConfigCount() == 0
&& data.getHttpEventCollectorChannelConfigCount() == 0) {
&& data.getHttpEventCollectorChannelConfigCount() == 0
&& data.getGoogleSecopsIntegrationChannelConfigCount() == 0) {
throw Status.INVALID_ARGUMENT.withDescription("No config present").asRuntimeException();
}
data.getEmailChannelConfigList().forEach(this::validateEmailChannelConfig);
Expand All @@ -143,6 +145,8 @@ private void validateNotificationChannelMutableData(NotificationChannelMutableDa
.forEach(this::validateSyslogIntegrationChannelConfig);
data.getHttpEventCollectorChannelConfigList()
.forEach(this::validateHttpEventCollectorChannelConfig);
data.getGoogleSecopsIntegrationChannelConfigList()
.forEach(this::validateGoogleSecopsIntegrationChannelConfig);
}

public void validateGetAllNotificationChannelsRequest(
Expand Down Expand Up @@ -234,6 +238,13 @@ private void validateSyslogIntegrationChannelConfig(
SyslogIntegrationChannelConfig.SYSLOG_SERVER_INTEGRATION_ID_FIELD_NUMBER);
}

private void validateGoogleSecopsIntegrationChannelConfig(
GoogleSecopsIntegrationChannelConfig googleSecopsIntegrationChannelConfig) {
validateNonDefaultPresenceOrThrow(
googleSecopsIntegrationChannelConfig,
GoogleSecopsIntegrationChannelConfig.GOOGLE_SECOPS_INTEGRATION_ID_FIELD_NUMBER);
}

private void validateNonDuplicateNotificationChannelOrThrow(
@Nullable String id,
String channelName,
Expand Down
Loading