Skip to content

Conversation

@SrikarMannepalli
Copy link
Contributor

Description

Added span processing config service.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #94 (a568de6) into main (6c1efb5) will decrease coverage by 0.26%.
The diff coverage is 79.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #94      +/-   ##
============================================
- Coverage     83.48%   83.21%   -0.27%     
- Complexity      319      341      +22     
============================================
  Files            38       43       +5     
  Lines          1580     1698     +118     
  Branches         51       51              
============================================
+ Hits           1319     1413      +94     
- Misses          223      246      +23     
- Partials         38       39       +1     
Flag Coverage Δ
integration 83.21% <79.66%> (-0.27%) ⬇️
unit 82.44% <79.48%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ig/service/SpanProcessingConfigServiceFactory.java 0.00% <0.00%> (ø)
...fig/service/SpanProcessingConfigServiceModule.java 62.50% <62.50%> (ø)
...onfig/service/SpanProcessingConfigServiceImpl.java 82.60% <82.60%> (ø)
...fig/service/store/ExcludeSpanRulesConfigStore.java 83.33% <83.33%> (ø)
...lidation/SpanProcessingConfigRequestValidator.java 84.00% <84.00%> (ø)
...pertrace/config/service/ConfigServicesFactory.java 66.66% <100.00%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c1efb5...a568de6. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@SrikarMannepalli SrikarMannepalli marked this pull request as ready for review February 18, 2022 07:01
@github-actions

This comment has been minimized.

@SrikarMannepalli SrikarMannepalli merged commit 2b83850 into main Feb 18, 2022
@SrikarMannepalli SrikarMannepalli deleted the add-span-processing-config-service branch February 18, 2022 07:44
@github-actions
Copy link

Unit Test Results

24 files  +3  24 suites  +3   43s ⏱️ +6s
88 tests +6  88 ✔️ +6  0 💤 ±0  0 ❌ ±0 

Results for commit 2b83850. ± Comparison against base commit 6c1efb5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants