add enable/disable support for exclude span rules #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #97 +/- ##
=========================================
Coverage 83.23% 83.24%
Complexity 343 343
=========================================
Files 44 44
Lines 1730 1731 +1
Branches 51 51
=========================================
+ Hits 1440 1441 +1
Misses 251 251
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
skjindal93
reviewed
Feb 25, 2022
| message UpdateExcludeSpanRule { | ||
| string id = 1; | ||
| string name = 2; | ||
| optional string name = 2; |
Contributor
There was a problem hiding this comment.
Why optionals? Clients can send the same values in the update messages (if they really want to keep them as same values). And, they would be updated as is. We shouldn't really be caring about the presence of these values
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
skjindal93
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.