Add docker jre images for java 11 and 14

[ravisingal]

No description provided.

[aaron-steinfeld]

tag name transform is to modify existing tags (we'd be mapping multiple to the same here, and couldn't support multiple). It seems like we just want to create our own tags here, so instead, let's remove the built in tags and add the ones we want.

  defaultImage {
    imageName.set("java")
    tags.forEach { it.onlyIf { false } }
    tag("11.0.8") // IMO, this one isn't needed but we can discuss
    tag("11")
  }

[ravisingal]

updated the tags of the image. IMO, it is a good practice to publish the minor version so that we can always pin version in our services.

[aaron-steinfeld]

The minor version isn't specified anywhere but in our own tag - so we're assuming that azul/zulu-openjdk-debian:11 will be on 11.0.8 - which is build time dependent. In other words, this can't be rebuilt consistently. If we think the minor version is important (I'm skeptical), we should parameterize it so we're using a from version that matches our own tag.

[ravisingal]

pinned azul image version in Dockerfile.

[aaron-steinfeld]

could we make that a parameter from gradle (it supports build args) - that way, the version is only defined in place and we don't accidentally get out of sync.

[ravisingal]

done.

[aaron-steinfeld]

Also a heads up, this sill isn't publishing. Since we're not using the tag in the version, we can also removing creating and pushing the tag.

[aaron-steinfeld]

Approving, but I assume we want to bring in publishing before merging this? Here are my local changes to remove versioning and restore publishing:

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 401a25b..948cfe4 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -53,12 +53,6 @@ jobs:
     executor: gradle_docker
     steps:
       - setup_build_environment
-      - gradle:
-          args: :tag -Prelease
-      - add_ssh_keys:
-          fingerprints:
-            - '9f:bb:a7:39:fa:3d:39:04:bd:c6:66:27:79:b1:49:86'
-      - run: git push origin $(./gradlew -q :printVersion)
       - gradle:
           args: dockerPushImages
 
@@ -67,11 +61,11 @@ workflows:
   build-and-publish:
     jobs:
       - build
-#      - publish:
-#          context: hypertrace-publishing
-#          requires:
-#            - build
-#          filters:
-#            branches:
-#              only:
-#                - main
+      - publish:
+          context: hypertrace-publishing
+          requires:
+            - build
+          filters:
+            branches:
+              only:
+                - main
diff --git a/semantic-build-versioning.gradle b/semantic-build-versioning.gradle
deleted file mode 100644
index 9bc1676..0000000
--- a/semantic-build-versioning.gradle
+++ /dev/null
@@ -1,11 +0,0 @@
-// Follows https://www.conventionalcommits.org/en/v1.0.0/#summary with one change: any commit is treated as a release,
-// patch being the default if major or minor is not detected.
-
-autobump {
-  // match any message starting with a type/scope suffixed with !, or with a line starting with "BREAKING CHANGE:"
-  majorPattern = ~/(?m)(\A[^:]+(?<=!): |^BREAKING CHANGE:)/
-  // match any commit message starting with "feat: " or "feat(any scope): "
-  minorPattern = ~/^feat(\([^)]+\))?: /
-  newPreReleasePattern = null // Not used - no prereleases
-  promoteToReleasePattern = null // Not used - every merge is a release
-}
\ No newline at end of file
diff --git a/settings.gradle.kts b/settings.gradle.kts
index 2f9ac12..c79b4ee 100644
--- a/settings.gradle.kts
+++ b/settings.gradle.kts
@@ -6,10 +6,5 @@ pluginManagement {
   }
 }
 
-plugins {
-  id("org.hypertrace.version-settings") version "0.1.5"
-}
-
-
 include(":java-8")
 include(":java-11")
\ No newline at end of file

[buchi-busireddy]

@ravisingal we don't use spring right? do we need these?

[buchi-busireddy]

Though I don't have full context on this, re-approving since @aaron-steinfeld seems to have already reviewed and approved it and he's offline now. This will be unblocking @ravisingal
If there are any comments, let's take them as new PRs.