Skip to content

Adding jdk.net module since it's needed by Mongo java driver. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Adding jdk.net module since it's needed by Mongo java driver. #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion java-11/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ jdk.crypto.ec,\
java.security.jgss,\
jdk.security.auth,\
# sun.misc.Unsafe and friends
jdk.unsupported\
jdk.unsupported,\
# jdk specific network options
jdk.net\
Copy link

@tim-mwangi tim-mwangi Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big increase in image size?

Copy link
Contributor Author

@buchi-busireddy buchi-busireddy Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I don't see any increase in the image size at all.

Previously:

hypertrace/java                                                     11                                               4bbacc3c72ef        2 weeks ago         102MB

Now:

hypertrace/java                                                     11                                               5240110aebd4        5 seconds ago       102MB

Copy link

@tim-mwangi tim-mwangi Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

--output jre

# We extract JRE's hard dependencies, libz and SSL certs, from the fat JRE image.
Expand Down
4 changes: 3 additions & 1 deletion java-14/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ jdk.crypto.ec,\
java.security.jgss,\
jdk.security.auth,\
# sun.misc.Unsafe and friends
jdk.unsupported\
jdk.unsupported,\
# jdk specific network options
jdk.net\
--output jre

# We extract JRE's hard dependencies, libz and SSL certs, from the fat JRE image.
Expand Down