Unnest on nested json arrays in flat collections #244
Merged
+97
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suddendust
requested review from
avinashkolluru,
kotharironak,
skjindal93 and
suresh-prakash
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
============================================
+ Coverage 80.08% 80.10% +0.01%
Complexity 1134 1134
============================================
Files 215 215
Lines 5484 5488 +4
Branches 481 482 +1
============================================
+ Hits 4392 4396 +4
Misses 764 764
Partials 328 328
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
suresh-prakash
previously approved these changes
Oct 22, 2025
| Returns the column name with double quotes if the collection is flat to prevent folding to lower-case by PG | ||
| */ | ||
| private String getColName(boolean isFlatCollection, String pgColumnName) { | ||
| private String shouldQuoteColName(boolean isFlatCollection, String pgColumnName) { |
There was a problem hiding this comment.
The new method name seems like it would return a boolean.
There was a problem hiding this comment.
Ah! Will fix it.
suddendust
changed the title
suresh-prakash
approved these changes
Oct 22, 2025
suddendust
changed the title
suddendust
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for
UNNESTon nester arrays in anyJSONBcolumn in flat collections.Checklist: