ci: migrating to GitHub actions #69
Conversation
JBAhire
requested review from
avinashkolluru,
buchi-busireddy,
inespo,
kotharironak and
tim-mwangi
as code owners
aaron-steinfeld
left a comment
aaron-steinfeld
left a comment
There was a problem hiding this comment.
See comments from hypertrace/query-service#47
|
Now using new custom actions for
changes as per discussions here: hypertrace/query-service#47 changes are tested here: hypertrace/attribute-service#65 and merged here hypertrace/attribute-service#66 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
.github/workflows/merge-publish.yml
Outdated
| - name: Check out code | ||
| uses: actions/checkout@v2.3.4 | ||
| with: | ||
| ref: ${{github.event.pull_request.head.ref}} |
There was a problem hiding this comment.
This is needed only in pull_request_target context.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| with: | ||
| args: copyAllReports --output-dir=/tmp/test-reports | ||
|
|
||
| - name: Upload coverage to Codecov |
There was a problem hiding this comment.
We have to copy the integration test report too - right?
Need that step after integration test as well
There was a problem hiding this comment.
this copy runs after integrationTest is done and copies both unit test and integration test reports
There was a problem hiding this comment.
I have moved it below codecov to follow standard ordering we are following everywhere
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Unit Test Results 25 files 25 suites 19s ⏱️ Results for commit 330b0af. |
Description
Migrating to GitHub actions from CircleCI as per hypertrace/hypertrace#144