Skip to content

Conversation

@aaron-steinfeld
Copy link
Contributor

@aaron-steinfeld aaron-steinfeld commented Jul 10, 2021

Description

Some small refactors to make the abstract backend more extendible

Testing

UTs, sanity tested it e2e via docker compose

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@aaron-steinfeld aaron-steinfeld requested a review from a team July 10, 2021 02:20
@codecov
Copy link

codecov bot commented Jul 10, 2021

Codecov Report

Merging #219 (189762b) into main (62ba4b5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #219   +/-   ##
=========================================
  Coverage     80.75%   80.75%           
- Complexity     1125     1127    +2     
=========================================
  Files           101      101           
  Lines          4345     4345           
  Branches        398      398           
=========================================
  Hits           3509     3509           
  Misses          650      650           
  Partials        186      186           
Flag Coverage Δ
unit 80.75% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...richers/backend/AbstractBackendEntityEnricher.java 85.71% <100.00%> (ø)
...richer/enrichment/enrichers/cache/EntityCache.java 94.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62ba4b5...189762b. Read the comment docs.

@github-actions

This comment has been minimized.


private Builder getBackendEntityBuilder(BackendType type, String backendURI, Event event) {
protected Builder getBackendEntityBuilder(
BackendType type, String backendURI, Event event, StructuredTrace trace) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the newly passed argument -StructuredTrace trace is not used. I am assuming it requires a follow-up, right?

Copy link
Contributor Author

@aaron-steinfeld aaron-steinfeld Jul 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not currently used in the abstract version, no - but as we migrate attribute retrieval from utils to the reader pattern, the reader always requires the trace.

@aaron-steinfeld aaron-steinfeld merged commit 1885e7c into main Jul 11, 2021
@aaron-steinfeld aaron-steinfeld deleted the refactor-entity-creation branch July 11, 2021 13:02
@github-actions
Copy link

Unit Test Results

  69 files  ±0    69 suites  ±0   50s ⏱️ -3s
358 tests ±0  358 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1885e7c. ± Comparison against base commit 62ba4b5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants