feat: stop populating first class event fields #222
Conversation
findingrish
left a comment
findingrish
left a comment
There was a problem hiding this comment.
Build is failing, tests have to be updated accordingly
But, do we need this test now? It's trying to covert to RawSpna. I can use a field generator. |
Codecov Report
@@ Coverage Diff @@
## main #222 +/- ##
============================================
- Coverage 80.69% 80.50% -0.20%
+ Complexity 1129 1126 -3
============================================
Files 101 101
Lines 4352 4349 -3
Branches 400 400
============================================
- Hits 3512 3501 -11
- Misses 654 659 +5
- Partials 186 189 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
| rawSpan.getEvent().getHttp().getRequest().getUserAgent(), | ||
| HttpSemanticConventionUtils.getHttpUserAgent(rawSpan.getEvent()).get()); | ||
| // now, we are not populating first class fields. So, it should be null. | ||
| assertNull(rawSpan.getEvent().getHttp()); |
There was a problem hiding this comment.
Isn't this repetitive/irrelevant in every test ? Maybe we can have another test just checking nullity of first class fields?
There was a problem hiding this comment.
I kept it after - RawSpan rawSpan = normalizer.convert("tenant-key", span); - convert call.
|
We need to merge the changes from main too |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Description
This is in the context of
Testing
Note