Skip to content

Conversation

@avinashkolluru
Copy link
Contributor

@avinashkolluru avinashkolluru commented Jul 22, 2021

Description

Add the ability to drop root spans based on a tag match criteria. Also allow for exclusions to override the behavior.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #231 (80125b6) into main (35fdfb3) will increase coverage by 0.04%.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #231      +/-   ##
============================================
+ Coverage     80.47%   80.51%   +0.04%     
- Complexity     1131     1143      +12     
============================================
  Files           101      101              
  Lines          4363     4388      +25     
  Branches        403      409       +6     
============================================
+ Hits           3511     3533      +22     
- Misses          662      663       +1     
- Partials        190      192       +2     
Flag Coverage Δ
unit 80.51% <93.33%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ertrace/core/spannormalizer/jaeger/SpanFilter.java 87.03% <92.68%> (+0.83%) ⬆️
.../spannormalizer/jaeger/JaegerSpanPreProcessor.java 66.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35fdfb3...80125b6. Read the comment docs.

@github-actions

This comment has been minimized.

* spans which have all 3 attribute:value pairs.
*/
private static final String SPAN_DROP_CRITERION_CONFIG = "processor.spanDropCriterion";
public static final String SPAN_DROP_CRITERION_CONFIG = "processor.spanDropCriterion";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't processor.rootSpanDropCriterion be covered in processor.spanDropCriterion itself?

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@findingrish findingrish marked this pull request as ready for review July 23, 2021 08:01
@findingrish findingrish requested a review from a team July 23, 2021 08:01
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@avinashkolluru avinashkolluru merged commit f0f194c into main Jul 23, 2021
@avinashkolluru avinashkolluru deleted the root_span_drop_criteria_support branch July 23, 2021 08:25
@github-actions
Copy link

Unit Test Results

  69 files  ±0    69 suites  ±0   46s ⏱️ -1s
364 tests +3  364 ✔️ +3  0 💤 ±0  0 ❌ ±0 

Results for commit f0f194c. ± Comparison against base commit 35fdfb3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants