-
Notifications
You must be signed in to change notification settings - Fork 16
Add support for filtering root spans matching a criteria #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #231 +/- ##
============================================
+ Coverage 80.47% 80.51% +0.04%
- Complexity 1131 1143 +12
============================================
Files 101 101
Lines 4363 4388 +25
Branches 403 409 +6
============================================
+ Hits 3511 3533 +22
- Misses 662 663 +1
- Partials 190 192 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
| * spans which have all 3 attribute:value pairs. | ||
| */ | ||
| private static final String SPAN_DROP_CRITERION_CONFIG = "processor.spanDropCriterion"; | ||
| public static final String SPAN_DROP_CRITERION_CONFIG = "processor.spanDropCriterion"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't processor.rootSpanDropCriterion be covered in processor.spanDropCriterion itself?
Description
Add the ability to drop root spans based on a tag match criteria. Also allow for exclusions to override the behavior.
Checklist: