Remove the default port during http resolution based on protocol. Thi… #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s will help reduce number of resolved backend http entity.
Codecov Report
@@ Coverage Diff @@
## main #233 +/- ##
============================================
+ Coverage 80.43% 80.47% +0.03%
- Complexity 1126 1131 +5
============================================
Files 101 101
Lines 4355 4363 +8
Branches 400 403 +3
============================================
+ Hits 3503 3511 +8
Misses 662 662
Partials 190 190
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
tim-mwangi
previously approved these changes
Jul 22, 2021
Contributor
kotharironak
left a comment
kotharironak
left a comment
There was a problem hiding this comment.
Do we need to take for other protocols and backend entity?
Specifically for HTTP, looks fine.
.../org/hypertrace/traceenricher/enrichment/enrichers/backend/provider/HttpBackendProvider.java
Show resolved
Hide resolved
.../org/hypertrace/traceenricher/enrichment/enrichers/backend/provider/HttpBackendProvider.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
findingrish
approved these changes
Jul 23, 2021
kotharironak
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the default port during http resolution based on protocol. This will help reduce number of resolved backend http entity.