Skip to content

Conversation

@avinashkolluru
Copy link
Contributor

Description

Optimization to avoid parsing repetitive user agent strings

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #241 (8399df3) into main (18f118c) will decrease coverage by 0.25%.
The diff coverage is 17.64%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #241      +/-   ##
============================================
- Coverage     80.64%   80.39%   -0.26%     
- Complexity     1148     1149       +1     
============================================
  Files           101      101              
  Lines          4422     4437      +15     
  Branches        412      414       +2     
============================================
+ Hits           3566     3567       +1     
- Misses          663      675      +12     
- Partials        193      195       +2     
Flag Coverage Δ
unit 80.39% <17.64%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...er/enrichment/enrichers/UserAgentSpanEnricher.java 67.27% <17.64%> (-22.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18f118c...8399df3. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@avinashkolluru avinashkolluru marked this pull request as ready for review July 31, 2021 07:12
@avinashkolluru avinashkolluru requested a review from a team July 31, 2021 07:12
@avinashkolluru avinashkolluru merged commit 4cc59db into main Jul 31, 2021
@avinashkolluru avinashkolluru deleted the optimize_ua_parser branch July 31, 2021 07:12
@github-actions
Copy link

Unit Test Results

  69 files  ±0    69 suites  ±0   47s ⏱️ -3s
365 tests ±0  365 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4cc59db. ± Comparison against base commit 18f118c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants