Skip to content

Introducing mechanism to allow/disallow backend resolution in the imp… #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Introducing mechanism to allow/disallow backend resolution in the imp… #244

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
887c800
Introducing mechanism to allow/disallow backend resolution in the imp…
Aug 3, 2021
9fb8794
Address review comment
Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .../hypertrace/traceenricher/enrichment/enrichers/backend/AbstractBackendEntityEnricher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ public void enrichTrace(StructuredTrace trace) {
.filter(
event ->
EnrichedSpanUtils.isExitSpan(event)
&& SpanAttributeUtils.isLeafSpan(structuredTraceGraph, event))
&& SpanAttributeUtils.isLeafSpan(structuredTraceGraph, event)
&& canResolveBackend(structuredTraceGraph, event))
// resolve backend entity
.map(event -> Pair.of(event, resolve(event, trace, structuredTraceGraph)))
.filter(pair -> pair.getRight().isPresent())
Expand All @@ -107,6 +108,19 @@ public void enrichTrace(StructuredTrace trace) {
}
}

/**
* Method to check if backend resolution should proceed. This will enable any custom logic to be
* inserted in the implementing classes.
*
* @param structuredTraceGraph structured trace graph
* @param event leaf exit span
* @return true if backend resolution is allowed
*/
protected boolean canResolveBackend(StructuredTraceGraph structuredTraceGraph, Event event) {
// by default allow the backend resolution to proceed
return true;
}

/** Checks if the candidateEntity is indeed a backend Entity */
private boolean isValidBackendEntity(
StructuredTrace trace, Event backendSpan, BackendInfo candidateInfo) {
Expand Down