Skip to content

Conversation

@aaron-steinfeld
Copy link
Contributor

Description

Entity IDs that are present but empty strings attempt to create an invalid entity. This change filters out invalid values.

Testing

Added UTs

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@aaron-steinfeld aaron-steinfeld requested a review from a team August 4, 2021 21:31
@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #247 (0f3a1bf) into main (77d9b63) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #247      +/-   ##
============================================
+ Coverage     80.28%   80.30%   +0.01%     
  Complexity     1150     1150              
============================================
  Files           101      101              
  Lines          4444     4447       +3     
  Branches        416      416              
============================================
+ Hits           3568     3571       +3     
  Misses          680      680              
  Partials        196      196              
Flag Coverage Δ
unit 80.30% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...race/reader/entities/DefaultTraceEntityReader.java 96.73% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77d9b63...0f3a1bf. Read the comment docs.

@github-actions

This comment has been minimized.

@aaron-steinfeld aaron-steinfeld merged commit fb0e15a into main Aug 4, 2021
@aaron-steinfeld aaron-steinfeld deleted the entity-reader-empty-id branch August 4, 2021 23:09
@github-actions
Copy link

github-actions bot commented Aug 4, 2021

Unit Test Results

  69 files  ±0    69 suites  ±0   56s ⏱️ +10s
366 tests +1  366 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit fb0e15a. ± Comparison against base commit 77d9b63.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants