Skip to content

Enabled reporting of user agent cache metrics #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Enabled reporting of user agent cache metrics #263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...rc/main/java/org/hypertrace/traceenricher/enrichment/enrichers/UserAgentSpanEnricher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import com.google.common.cache.CacheLoader;
import com.google.common.cache.LoadingCache;
import com.typesafe.config.Config;
import java.util.Collections;
import java.util.Map;
import java.util.Optional;
import javax.annotation.Nullable;
Expand All @@ -15,6 +16,7 @@
import org.hypertrace.core.datamodel.Event;
import org.hypertrace.core.datamodel.StructuredTrace;
import org.hypertrace.core.datamodel.shared.trace.AttributeValueCreator;
import org.hypertrace.core.serviceframework.metrics.PlatformMetricsRegistry;
import org.hypertrace.semantic.convention.utils.http.HttpSemanticConventionUtils;
import org.hypertrace.semantic.convention.utils.rpc.RpcSemanticConventionUtils;
import org.hypertrace.traceenricher.enrichedspan.constants.EnrichedSpanConstants;
Expand All @@ -31,6 +33,7 @@ public class UserAgentSpanEnricher extends AbstractTraceEnricher {
private static final int CACHE_MAX_SIZE_DEFAULT = 10000;
private static final String USER_AGENT_MAX_LENGTH_KEY = "user.agent.max.length";
private static final int DEFAULT_USER_AGENT_MAX_LENGTH = 1000;
private static final String DOT = ".";
private final UserAgentStringParser userAgentStringParser =
UADetectorServiceFactory.getResourceModuleParser();
@Nullable private LoadingCache<String, ReadableUserAgent> userAgentCache;
Expand All @@ -56,6 +59,10 @@ public ReadableUserAgent load(String userAgentString) {
return userAgentStringParser.parse(userAgentString);
}
});
PlatformMetricsRegistry.registerCache(
this.getClass().getName() + DOT + "userAgentCache",
userAgentCache,
Collections.emptyMap());
}
if (enricherConfig.hasPath(USER_AGENT_MAX_LENGTH_KEY)) {
userAgentMaxLength = enricherConfig.getInt(USER_AGENT_MAX_LENGTH_KEY);
Expand Down