Skip to content

Conversation

@laxmanchekka
Copy link
Contributor

Description

We need enricher-wise metrics to identify the bottlenecks specific to enricher implementations.

Testing

Tested on a dev SaaS cluster

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #265 (84cdd20) into main (be215f0) will decrease coverage by 0.15%.
The diff coverage is 67.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #265      +/-   ##
============================================
- Coverage     80.35%   80.20%   -0.16%     
  Complexity     1162     1162              
============================================
  Files           102      102              
  Lines          4506     4512       +6     
  Branches        420      421       +1     
============================================
- Hits           3621     3619       -2     
- Misses          688      695       +7     
- Partials        197      198       +1     
Flag Coverage Δ
unit 80.20% <67.85%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...trace/enricher/StructuredTraceEnrichProcessor.java 88.88% <ø> (-4.30%) ⬇️
.../traceenricher/enrichment/EnrichmentProcessor.java 74.35% <67.85%> (-3.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be215f0...84cdd20. Read the comment docs.

@github-actions

This comment has been minimized.

// Must use linked hashmap
private final Map<String, Enricher> enrichers = new LinkedHashMap<>();

private static final String ENRICHED_TRACES_COUNTER = "hypertrace.enriched.traces";
Copy link
Contributor

@avinashkolluru avinashkolluru Oct 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: We can get rid of the hypertrace. prefix in both the metric names

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the metric convention we are using across hypertrace projects.
Also, this may cause compatibility issue if we change the name and existing dashboards may be broken.

@kotharironak @rish691: please confirm if changing and simplifying this metric name is okay?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is exposed in ready to use dashboard - https://github.com/hypertrace/hypertrace/tree/main/kubernetes/monitoring/dashboards. So would suggest keeping it as is now. And, we can clean up if we decided to go with metrics.reporter based prefix only in application.conf

@laxmanchekka laxmanchekka merged commit dd0a5fb into main Oct 5, 2021
@laxmanchekka laxmanchekka deleted the enricher-metrics branch October 5, 2021 12:04
@github-actions
Copy link

github-actions bot commented Oct 5, 2021

Unit Test Results

  70 files  ±0    70 suites  ±0   56s ⏱️ -1s
379 tests ±0  379 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit dd0a5fb. ± Comparison against base commit be215f0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants