Skip to content

Conversation

@avinashkolluru
Copy link
Contributor

@avinashkolluru avinashkolluru commented Nov 18, 2021

Description

Fixed the span drop criteria parsing logic which fails if the the tag value has the delimeter(:)

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

- Splitting tag key/value match condition based on the first colon
@avinashkolluru avinashkolluru requested a review from a team November 18, 2021 11:44
@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #287 (0113676) into main (6d111a2) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #287      +/-   ##
============================================
+ Coverage     79.16%   79.20%   +0.03%     
- Complexity     1238     1239       +1     
============================================
  Files           111      111              
  Lines          4881     4880       -1     
  Branches        443      442       -1     
============================================
+ Hits           3864     3865       +1     
  Misses          813      813              
+ Partials        204      202       -2     
Flag Coverage Δ
unit 79.20% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ertrace/core/spannormalizer/jaeger/SpanFilter.java 88.33% <100.00%> (+3.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d111a2...0113676. Read the comment docs.

@github-actions

This comment has been minimized.

Copy link
Contributor

@kotharironak kotharironak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avinashkolluru avinashkolluru merged commit 85a92cc into main Nov 18, 2021
@avinashkolluru avinashkolluru deleted the bugfix/spanDropFilter_parsing branch November 18, 2021 11:52
@github-actions
Copy link

Unit Test Results

  74 files  ±0    74 suites  ±0   1m 2s ⏱️ +4s
389 tests ±0  389 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 85a92cc. ± Comparison against base commit 6d111a2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants