-
Notifications
You must be signed in to change notification settings - Fork 16
grouper/enricher produces/consumes keyed input #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #314 +/- ##
=========================================
Coverage 79.94% 79.94%
Complexity 1365 1365
=========================================
Files 125 125
Lines 5384 5384
Branches 489 489
=========================================
Hits 4304 4304
Misses 857 857
Partials 223 223
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
kotharironak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Can you check snyk issues?
| import org.apache.kafka.streams.TestInputTopic; | ||
| import org.apache.kafka.streams.TestOutputTopic; | ||
| import org.apache.kafka.streams.TopologyTestDriver; | ||
| import org.apache.kafka.streams.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to be specific? Or was this auto-suggested of replacing to * import?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done by spotless I guess. it prefers wildcard when number of classes used are more than a threshold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must be done by IDE. AFAIK spotless doesn't make this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we need to set a high number like 999 as import class count to be optimised with * in intellij.
|
Description
grouper produces keyed output
enricher produces keyed input
Testing
Unit tests
Checklist:
Documentation
NA