Skip to content

Conversation

@laxmanchekka
Copy link
Contributor

Description

grouper produces keyed output
enricher produces keyed input

Testing

Unit tests

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

NA

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #314 (feae75d) into main (ef63989) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #314   +/-   ##
=========================================
  Coverage     79.94%   79.94%           
  Complexity     1365     1365           
=========================================
  Files           125      125           
  Lines          5384     5384           
  Branches        489      489           
=========================================
  Hits           4304     4304           
  Misses          857      857           
  Partials        223      223           
Flag Coverage Δ
unit 79.94% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...trace/enricher/StructuredTraceEnrichProcessor.java 86.84% <ø> (ø)
...rtrace/core/rawspansgrouper/RawSpansProcessor.java 81.57% <ø> (ø)
...ce/traceenricher/trace/enricher/TraceEnricher.java 72.72% <100.00%> (ø)
...pertrace/core/rawspansgrouper/RawSpansGrouper.java 90.00% <100.00%> (ø)
...race/core/rawspansgrouper/TraceEmitPunctuator.java 75.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef63989...feae75d. Read the comment docs.

@github-actions

This comment has been minimized.

Copy link
Contributor

@kotharironak kotharironak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Can you check snyk issues?

import org.apache.kafka.streams.TestInputTopic;
import org.apache.kafka.streams.TestOutputTopic;
import org.apache.kafka.streams.TopologyTestDriver;
import org.apache.kafka.streams.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to be specific? Or was this auto-suggested of replacing to * import?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done by spotless I guess. it prefers wildcard when number of classes used are more than a threshold

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be done by IDE. AFAIK spotless doesn't make this change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to set a high number like 999 as import class count to be optimised with * in intellij.

@laxmanchekka
Copy link
Contributor Author

lgtm

Can you check snyk issues?
@kotharironak : vulnerability is from data-model. we need to fix it separately and upgrade the lib here.

@laxmanchekka laxmanchekka merged commit a4e8fa4 into main Mar 28, 2022
@laxmanchekka laxmanchekka deleted the grouper-keyed-output branch March 28, 2022 12:53
@github-actions
Copy link

Unit Test Results

  76 files  ±0    76 suites  ±0   1m 4s ⏱️ +4s
408 tests ±0  408 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a4e8fa4. ± Comparison against base commit ef63989.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants