Skip to content

chore | adding should resolve backend uri function #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 22, 2022
Merged

chore | adding should resolve backend uri function #359

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
709621a
chore | adding should resolve backend uri function
aman-bansal Nov 22, 2022
5a028e6
fixing the url
aman-bansal Nov 22, 2022
041aa1d
making it pretty
aman-bansal Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .../hypertrace/traceenricher/enrichment/enrichers/backend/AbstractBackendEntityEnricher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,18 @@ protected boolean canResolveBackend(StructuredTraceGraph structuredTraceGraph, E
return true;
}

/**
* Method to check if backend uri is valid or not. This will enable any custom logic to be
* inserted in the implementing classes.
*
* @param backendURI backend URI information
* @return true if backend uri resolution is allowed
*/
protected boolean isValidBackendUri(String backendURI) {
// by default allow the backend uri to proceed
return true;
}

/** Checks if the candidateEntity is indeed a backend Entity */
private boolean isValidBackendEntity(
StructuredTrace trace, Event backendSpan, BackendInfo candidateInfo) {
Expand Down Expand Up @@ -311,8 +323,11 @@ public Optional<BackendInfo> resolve(
}

String backendUri = maybeBackendUri.get();
final Builder entityBuilder = getEntityBuilder(trace, event, type, backendUri);
if (!isValidBackendUri(backendUri)) {
return Optional.empty();
}

final Builder entityBuilder = getEntityBuilder(trace, event, type, backendUri);
backendProvider.getEntityAttributes(event).forEach(entityBuilder::putAttributes);
Map<String, org.hypertrace.core.datamodel.AttributeValue> enrichedAttributes =
new HashMap<>();
Expand Down