Skip to content

chore | evaluate enriched backend entity attributes before updating #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 19, 2023
Merged

chore | evaluate enriched backend entity attributes before updating #402

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ee1516
chore | evaluate entity attributes for all spans
aman-bansal Jul 18, 2023
333295f
fix
aman-bansal Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .../hypertrace/traceenricher/enrichment/enrichers/backend/AbstractBackendEntityEnricher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,11 @@ protected Map<String, AttributeValue> getIdentifyingAttributes(
return Collections.unmodifiableMap(identifyingAttributes);
}

protected Map<String, AttributeValue> getEnrichedEntityAttributes(
StructuredTrace trace, Event event, BackendType type, String backendURI) {
return Collections.emptyMap();
}

@VisibleForTesting
public Optional<BackendInfo> resolve(
Event event, StructuredTrace trace, StructuredTraceGraph structuredTraceGraph) {
Expand Down Expand Up @@ -337,6 +342,9 @@ public Optional<BackendInfo> resolve(

final Builder entityBuilder = getEntityBuilder(trace, event, type, backendUri);
backendProvider.getEntityAttributes(event).forEach(entityBuilder::putAttributes);
Map<String, AttributeValue> entityAttributes =
getEnrichedEntityAttributes(trace, event, type, backendUri);
entityBuilder.putAllAttributes(entityAttributes);
Map<String, org.hypertrace.core.datamodel.AttributeValue> enrichedAttributes =
new HashMap<>();
Optional<String> backendOperation = backendProvider.getBackendOperation(event);
Expand Down