optimised docker e2e test with GH action #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #89 +/- ##
=========================================
Coverage 68.75% 68.75%
Complexity 815 815
=========================================
Files 83 83
Lines 3441 3441
Branches 367 367
=========================================
Hits 2366 2366
Misses 931 931
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| matrix: | ||
| docker-version: [19.03] | ||
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-20.04 |
Contributor
There was a problem hiding this comment.
can you add a comment here?
The workflow needs docker and java versions, so it's better to know against what version it has been tested.
kotharironak
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While trying POC on GitHub action we realised that docker 19.03 and Java 11 are part of runner that comes with Ubuntu-20.04 already has those requirements satisfied. (ref: https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md)
Testing
NA
Documentation