Kafka streams config fix/tuning: hypertrace-ingester #91
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,4 +20,6 @@ test-output | |
| # Local config to handle using Java 8 vs java 11. | ||
| .java-version | ||
| *.tgz | ||
| # helm | ||
| charts/ | ||
| Chart.lock | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,7 +25,7 @@ nodeLabels: {} | |
| # This is defined in resources/configs/trace-enricher/application.conf as service.admin.port | ||
| containerAdminPort: 8099 | ||
|
|
||
| javaOpts: "-XX:InitialRAMPercentage=50.0 -XX:MaxRAMPercentage=75.0 -XX:MaxDirectMemorySize=128M" | ||
|
|
||
| livenessProbe: | ||
| initialDelaySeconds: 10 | ||
|
|
@@ -45,7 +45,7 @@ resources: | |
| memory: 1024Mi | ||
| limits: | ||
| cpu: 1.0 | ||
| memory: 1024Mi | ||
|
|
||
| podLabels: | ||
| app: hypertrace-trace-enricher | ||
|
|
@@ -65,13 +65,32 @@ deploymentSelectorMatchLabels: | |
| ########### | ||
| traceEnricherConfig: | ||
| name: hypertrace-trace-enricher-config | ||
| # Important kafka streams configurations which are used in config template goes here. | ||
| kafkaStreamsConfig: | ||
| bootstrapServers: "bootstrap:9092" | ||
| schemaRegistryUrl: "http://schema-registry-service:8081" | ||
| # Core config | ||
| numStreamThreads: 2 # default = 1 | ||
| commitIntervalMs: 30000 # default = 30000 | ||
| # Common client (producer, consumer, admin) configs | ||
| receiveBufferBytes: 4194304 # default = 32768 (kafka streams default) | ||
| sendBufferBytes: 4194304 # default = 131072 (kafka streams default) | ||
| # Producer configs | ||
| producerAcks: all # default: 1 | ||
| producerBatchSize: 524288 # default = 16384 | ||
| producerLingerMs: 1000 # default = 100 (kafka streams default) | ||
| producerCompressionType: "gzip" # default = none | ||
| producerMaxRequestSize: 10485760 # default = 1048576 | ||
| producerBufferMemory: 134217728 # default = 33554432 | ||
| # Consumer configs | ||
| consumerMaxPartitionFetchBytes: 4194304 # default = 1048576 | ||
| consumerMaxPollRecords: 1000 # default = 1000 (kafka streams default) | ||
|
Contributor
There was a problem hiding this comment. same comment as in https://github.com/hypertrace/hypertrace-ingester/pull/91/files#r549230957 |
||
| consumerSessionTimeoutMs: 10000 # default = 10000 | ||
| # Others | ||
| metricsRecordingLevel: INFO # default = INFO | ||
|
Contributor
There was a problem hiding this comment. same comment as in https://github.com/hypertrace/hypertrace-ingester/pull/91/files#r549230957 |
||
| # All other streams config goes here. | ||
| # Remove the flower braces and add key: value pair here. | ||
| extraKafkaStreamsConfig: {} | ||
|
|
||
| logConfig: | ||
| name: hypertrace-trace-enricher-log-config | ||
|
|
@@ -88,11 +107,12 @@ kafka-topic-creator: | |
| kafka: | ||
| topics: | ||
| - name: enriched-structured-traces | ||
| replicationFactor: 3 | ||
| partitions: 8 | ||
| configs: | ||
| - retention.bytes=8589934592 # default = -1 | ||
| - retention.ms=86400000 # default = 604800000 (7 days) | ||
| - max.message.bytes=10485760 # Allow larger messages for traces | ||
| zookeeper: | ||
| address: zookeeper:2181 | ||
| imagePullSecrets: [] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are keeping the default from kafka, does it make sense to add an
ifin the chart and thus not requiring us to pass a default? cc @JBAhireThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes the chart more complex by adding many if-else branches.
These are very important handpicked kafka/kafka-streams configs that needs to be tuned as per the application performance/throughput requirements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Do you think if we can put it as a commented block if a default is the same and it can be uncommented if some values need to be changed?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yah above will again need if/else block in the template which you mentioned. Got it now that this was done for keeping the template simple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if/else blocks saves us the need to define the defaults ourselves because it adds noise to a already big set of settings. I don't think we will have complex if { if else } else { if else }, it is just a simple if.