Skip to content

Correcting the dependency order for backend entity enricher #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 4, 2021
Merged

Correcting the dependency order for backend entity enricher #93

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ad4d5b
Correting the order for backend entity enricher
kotharironak Dec 30, 2020
8a09dff
Adding dependency on endpoint enricher
kotharironak Dec 30, 2020
37bc490
Merge branch 'main' into backend-as-service
kotharironak Dec 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ace-enricher/hypertrace-trace-enricher/src/main/resources/configs/common/application.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ enricher {
port = 50061
port = ${?ENTITY_SERVICE_PORT_CONFIG}
}
dependencies = ["DefaultServiceEntityEnricher"]
dependencies = ["DefaultServiceEntityEnricher", "EndpointEnricher"]
Copy link
Contributor

@findingrish findingrish Dec 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why do we have all this dependency information as part of config. Do we need to frequently change this order based on environment etc?

Copy link
Contributor

@buchi-busireddy buchi-busireddy Jan 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we change this based on the environment but we want to be able to enable/disable a given enricher.

}

ApiStatusEnricher {
Expand Down