Missing breadcrumb in Services

[jyothishjose6190]

To Reproduce the issue - Go to Services -> select any service ->. switch to endpoints tab -> Select any endpoint ->check breadcrumbs at the top

URL Pattern before selecting a single endpoint

URL After selecting a single endpoint

Here the selected service (eg: frontend ) is not part of URL. That is the reason.

[aaron-steinfeld]

Thanks for the report! It shouldn't need the service id in the url to get that info, since that's part of the endpoint's info, too, but will need to check the implementation.

[jyothishjose6190]

@aaron-steinfeld Did you get a chance to look at the implementation?

[aaron-steinfeld]

Sorry about that! Yes, so there are some issues there, but not what you're reporting here. This one's a bit interesting - I'm able to repro it, but it's not on the UI side.

We're firing the appropriate query:

{
  entities(
    scope: "API"
    limit: 1
    between: {startTime: "2021-08-13T04:02:16.503Z", endTime: "2021-08-13T05:02:16.503Z"}
    filterBy: [{operator: EQUALS, value: "94f61ecc-ce39-37d0-a49b-f2120827f2a5", type: ID, idType: API}]
    includeInactive: true
  ) {
    results {
      id
      name: attribute(key: "name")
      serviceName: attribute(key: "serviceName")
      serviceId: attribute(key: "serviceId")
      __typename
    }
    __typename
  }
}

but for whatever reason, the server is returning an empty string for that service name.

{
  "entities": {
    "results": [
      {
        "id": "94f61ecc-ce39-37d0-a49b-f2120827f2a5",
        "name": "HTTP GET /dispatch",
        "serviceName": "",
        "serviceId": "b89ddf9b-c582-3d93-9006-a4b3024cf5a5",
        "__typename": "Entity"
      }
    ],
    "__typename": "EntityResultSet"
  }
}

The funny thing is, the data is there.

Will try to look a little deeper, but may not be til tomorrow.

[jyothishjose6190]

Thanks

…

On Fri, 13 Aug 2021, 10:48 am Aaron Steinfeld, ***@***.***> wrote: Sorry about that! Yes, so there are some issues there, but not what you're reporting here. This one's a bit interesting - I'm able to repro it, but it's not on the UI side. We're firing the appropriate query: { entities( scope: "API" limit: 1 between: {startTime: "2021-08-13T04:02:16.503Z", endTime: "2021-08-13T05:02:16.503Z"} filterBy: [{operator: EQUALS, value: "94f61ecc-ce39-37d0-a49b-f2120827f2a5", type: ID, idType: API}] includeInactive: true ) { results { id name: attribute(key: "name") serviceName: attribute(key: "serviceName") serviceId: attribute(key: "serviceId") __typename } __typename } } but for whatever reason, the server is returning an empty string for that service name. { "entities": { "results": [ { "id": "94f61ecc-ce39-37d0-a49b-f2120827f2a5", "name": "HTTP GET /dispatch", "serviceName": "", "serviceId": "b89ddf9b-c582-3d93-9006-a4b3024cf5a5", "__typename": "Entity" } ], "__typename": "EntityResultSet" } } The funny thing is, the data is there. [image: image] <https://user-images.githubusercontent.com/45047841/129308398-5acc85f6-b8b8-4f2c-a073-a0b9df47e13e.png> Will try to look a little deeper, but may not be til tomorrow. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1061 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUXX7DD3TJKSEA7H45V7ATDT4STLHANCNFSM5B5O4LHQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

-- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- **IMPORTANT**: The contents of this email and any attachments are confidential and protected by applicable laws. If you have received this email by mistake, please (i) notify the sender immediately; (ii) delete it from your database; and (iii) do not disclose the contents to anyone or make copies thereof. Razorpay accepts no liability caused due to any inadvertent/ unintentional data transmitted through this email. -----------------------------------------------------------------------------------------------------------------------------------------------------------------------

[aaron-steinfeld]

ok so the issue is that this query was updated to use the "includeInactive" flag - meaning it synthesizes entities out of the entity store (mongo) rather than from span data (pinot). Looking at this api in the entity store, we can see the service name is missing. We'll have to update that on the data ingestion side:

{
  "_id": "__default:94f61ecc-ce39-37d0-a49b-f2120827f2a5",
  "_lastUpdateTime": {
    "$date": "2021-08-13T05:24:03.140Z"
  },
  "attributes": {
    "api_discovery_from": {
      "value": {
        "string": "OPERATION_NAME"
      }
    },
    "api_discovery_state": {
      "value": {
        "string": "DISCOVERED"
      }
    },
    "API_NAME": {
      "value": {
        "string": "HTTP GET /dispatch"
      }
    },
    "API_URL_PATTERN": {
      "value": {
        "string": "HTTP GET /dispatch"
      }
    },
    "SERVICE_ID": {
      "value": {
        "string": "b89ddf9b-c582-3d93-9006-a4b3024cf5a5"
      }
    },
    "API_TYPE": {
      "value": {
        "string": "OPERATION_NAME"
      }
    }
  },
  "createdTime": 1628832243139,
  "entityId": "94f61ecc-ce39-37d0-a49b-f2120827f2a5",
  "entityName": "HTTP GET /dispatch",
  "entityType": "API",
  "identifyingAttributes": {
    "API_URL_PATTERN": {
      "value": {
        "string": "HTTP GET /dispatch"
      }
    },
    "SERVICE_ID": {
      "value": {
        "string": "b89ddf9b-c582-3d93-9006-a4b3024cf5a5"
      }
    },
    "API_TYPE": {
      "value": {
        "string": "OPERATION_NAME"
      }
    }
  },
  "lastUpdatedTime": 1628832243139,
  "tenantId": "__default"
}

[aaron-steinfeld]

The attribute was updated with entity service support in https://github.com/hypertrace/config-bootstrapper/pull/53/files , but it's never written in https://github.com/hypertrace/hypertrace-ingester/blob/main/hypertrace-trace-enricher/hypertrace-trace-enricher-impl/src/main/java/org/hypertrace/traceenricher/enrichment/enrichers/endpoint/ApiEntityDao.java#L57-L67 - @skjindal93 do you mind taking this on?

[skjindal93]

The attribute was updated with entity service support in https://github.com/hypertrace/config-bootstrapper/pull/53/files , but it's never written in https://github.com/hypertrace/hypertrace-ingester/blob/main/hypertrace-trace-enricher/hypertrace-trace-enricher-impl/src/main/java/org/hypertrace/traceenricher/enrichment/enrichers/endpoint/ApiEntityDao.java#L57-L67 - @skjindal93 do you mind taking this on?

Sure, I can take this up

[JBAhire]

Thanks, @skjindal93 !