Skip to content

Conversation

@aaron-steinfeld
Copy link
Contributor

Description

update vulns, move from snyk to owasp vuln check

@github-actions
Copy link

github-actions bot commented Jun 15, 2023

Test Results

70 tests   70 ✔️  21s ⏱️
12 suites    0 💤
12 files      0

Results for commit 9990f36.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #46 (9990f36) into main (2136f89) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #46   +/-   ##
=========================================
  Coverage     73.65%   73.65%           
  Complexity      145      145           
=========================================
  Files            20       20           
  Lines           410      410           
  Branches         22       22           
=========================================
  Hits            302      302           
  Misses           85       85           
  Partials         23       23           
Flag Coverage Δ
unit 73.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@aaron-steinfeld
Copy link
Contributor Author

If anyone's able to review, this is blocking changes to all the other repos.

avinashkolluru
avinashkolluru previously approved these changes Jun 15, 2023
Copy link
Contributor

@kotharironak kotharironak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one question, but rest is fine.

- name: create checksum file
uses: hypertrace/github-actions/checksum@main

- name: Cache packages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: We no longer need gradle caches? Or is it done as part of some other action?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, the gradle action does the caching now. It delegates to gradle's own action which does a much better job than us. If you look at the build summary, it'll include details about this (no cache yet because only a merged branch can populate it https://github.com/hypertrace/java-grpc-utils/actions/runs/5280504792/attempts/1#summary-14294660225 )

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants