-
Couldn't load subscription status.
- Fork 0
refactor: update vulns, add dep check #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #46 +/- ##
=========================================
Coverage 73.65% 73.65%
Complexity 145 145
=========================================
Files 20 20
Lines 410 410
Branches 22 22
=========================================
Hits 302 302
Misses 85 85
Partials 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
If anyone's able to review, this is blocking changes to all the other repos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had one question, but rest is fine.
| - name: create checksum file | ||
| uses: hypertrace/github-actions/checksum@main | ||
|
|
||
| - name: Cache packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: We no longer need gradle caches? Or is it done as part of some other action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, the gradle action does the caching now. It delegates to gradle's own action which does a much better job than us. If you look at the build summary, it'll include details about this (no cache yet because only a merged branch can populate it https://github.com/hypertrace/java-grpc-utils/actions/runs/5280504792/attempts/1#summary-14294660225 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better example, after merging https://github.com/hypertrace/java-grpc-utils/actions/runs/5281004452/attempts/1#summary-14296270285
Description
update vulns, move from snyk to owasp vuln check