Disable reporting of standard database metrics #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suresh-prakash
requested review from
laxmanchekka,
madhavpcm,
ravisingal and
sanket-mundra
sanket-mundra
previously approved these changes
Feb 19, 2025
madhavpcm
previously approved these changes
Feb 19, 2025
...main/java/org/hypertrace/core/serviceframework/docstore/metrics/DocStoreMetricsRegistry.java
Outdated
Show resolved
Hide resolved
suresh-prakash
dismissed stale reviews from madhavpcm and sanket-mundra
via
9d5bcc1
aaron-steinfeld
previously approved these changes
Feb 19, 2025
laxmanchekka
previously approved these changes
Feb 19, 2025
ravisingal
previously approved these changes
Feb 20, 2025
suresh-prakash
dismissed stale reviews from ravisingal, laxmanchekka, and aaron-steinfeld
via
6a46aea
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
=========================================
Coverage 68.53% 68.53%
Complexity 107 107
=========================================
Files 17 17
Lines 623 623
Branches 32 32
=========================================
Hits 427 427
Misses 177 177
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
laxmanchekka
approved these changes
Feb 20, 2025
suresh-prakash
deleted the
disable_standard_database_metric_reporting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.