Skip to content

Conversation

@aaron-steinfeld
Copy link
Contributor

Description

The new grpc service factory container classes don't rely on environment variables for things like cluster (which were unused, and thus call the direct getConfig(x,y,z) method. This was unsupported for integration tests, so refactored to support both the prior and new styles.

Testing

Verified integration tests both in old service that hasn't been changed for backwards compat, and new service using the new grpc service factory style.

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #42 (a8f90f7) into main (68eddf3) will decrease coverage by 0.49%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main      #42      +/-   ##
============================================
- Coverage     69.57%   69.08%   -0.50%     
  Complexity      106      106              
============================================
  Files            15       15              
  Lines           562      566       +4     
  Branches         33       33              
============================================
  Hits            391      391              
- Misses          151      155       +4     
  Partials         20       20              
Flag Coverage Δ
unit 69.08% <0.00%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/serviceframework/config/ConfigClientFactory.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68eddf3...a8f90f7. Read the comment docs.

@github-actions

This comment has been minimized.

@aaron-steinfeld aaron-steinfeld merged commit f0f7dcb into main Jun 24, 2022
@aaron-steinfeld aaron-steinfeld deleted the int-test-fixes branch June 24, 2022 19:02
@github-actions
Copy link

Unit Test Results

  9 files  ±0    9 suites  ±0   7s ⏱️ ±0s
31 tests ±0  31 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f0f7dcb. ± Comparison against base commit 68eddf3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants