Skip to content

Max inbound #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Max inbound #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e276df
feat: support defining max inbound message size
aaron-steinfeld Jul 16, 2022
289950d
fix: use builders
aaron-steinfeld Jul 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...a/org/hypertrace/core/serviceframework/grpc/ConsolidatedGrpcPlatformServiceContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,11 @@ protected GrpcServiceContainerEnvironment buildContainerEnvironment(
@Override
protected List<GrpcPlatformServerDefinition> getServerDefinitions() {
return List.of(
new GrpcPlatformServerDefinition(
"networked-" + this.getServiceName(),
this.getServicePort(),
this.getServiceFactories()));
GrpcPlatformServerDefinition.builder()
.name("networked-" + this.getServiceName())
.port(this.getServicePort())
.serviceFactories(this.getServiceFactories())
.build());
}

/**
Expand Down
4 changes: 2 additions & 2 deletions ...src/main/java/org/hypertrace/core/serviceframework/grpc/GrpcPlatformServerDefinition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@
public class GrpcPlatformServerDefinition {
String name;
int port;
@Singular
Collection<GrpcPlatformServiceFactory> serviceFactories;
int maxInboundMessageSize;
@Singular Collection<GrpcPlatformServiceFactory> serviceFactories;
}
15 changes: 11 additions & 4 deletions ...src/main/java/org/hypertrace/core/serviceframework/grpc/GrpcPlatformServiceContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,7 @@ protected void doInit() {
this.grpcChannelRegistry = this.buildChannelRegistry();
Map<GrpcPlatformServerDefinition, ServerBuilder<?>> serverBuilderMap =
this.getServerDefinitions().stream()
.collect(
Collectors.toUnmodifiableMap(
Function.identity(),
definition -> ServerBuilder.forPort(definition.getPort())));
.collect(Collectors.toUnmodifiableMap(Function.identity(), this::initializeBuilder));
final ServerBuilder<?> inProcessServerBuilder =
InProcessServerBuilder.forName(this.getInProcessServerName())
.addService(this.healthStatusManager.getHealthService());
Expand Down Expand Up @@ -219,6 +216,16 @@ protected void registerManagedPeriodicTask(PlatformPeriodicTaskDefinition period
protected abstract GrpcServiceContainerEnvironment buildContainerEnvironment(
InProcessGrpcChannelRegistry channelRegistry, HealthStatusManager healthStatusManager);

private ServerBuilder<?> initializeBuilder(GrpcPlatformServerDefinition serverDefinition) {
ServerBuilder<?> builder = ServerBuilder.forPort(serverDefinition.getPort());

if (serverDefinition.getMaxInboundMessageSize() > 0) {
builder.maxInboundMessageSize(serverDefinition.getMaxInboundMessageSize());
}

return builder;
}

@Value
private static class ConstructedServer {
String name;
Expand Down
10 changes: 5 additions & 5 deletions ...ava/org/hypertrace/core/serviceframework/grpc/StandAloneGrpcPlatformServiceContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import io.grpc.protobuf.services.HealthStatusManager;
import java.util.List;
import java.util.Set;
import lombok.extern.slf4j.Slf4j;
import org.hypertrace.core.grpcutils.client.InProcessGrpcChannelRegistry;
import org.hypertrace.core.serviceframework.config.ConfigClient;
Expand Down Expand Up @@ -30,10 +29,11 @@ protected int getServicePort() {

protected List<GrpcPlatformServerDefinition> getServerDefinitions() {
return List.of(
new GrpcPlatformServerDefinition(
"networked-" + this.getServiceName(),
this.getServicePort(),
Set.of(this.getServiceFactory())));
GrpcPlatformServerDefinition.builder()
.name("networked-" + this.getServiceName())
.port(this.getServicePort())
.serviceFactory(this.getServiceFactory())
.build());
}

@Override
Expand Down