Skip to content

refactor: exit process if server fails to start #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2022
Merged

refactor: exit process if server fails to start #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions ...service-framework/src/main/java/org/hypertrace/core/serviceframework/PlatformService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,8 @@ public void start() {
adminServer.join();
} catch (Exception e) {
LOGGER.error("Failed to start service servlet.");
this.shutdown();
System.exit(1);
}
}

Expand Down Expand Up @@ -175,12 +177,6 @@ public void shutdown() {
} catch (Exception ex) {
LOGGER.error("Error stopping admin server");
}
if (getServiceState() != State.STARTED) {
LOGGER.info(
"Service - {} is at state: {}. Expecting state: STARTED. Skipping shutdown...",
getServiceName(), getServiceState());
return;
}
LOGGER.info("Trying to shutdown service - {}...", getServiceName());
serviceLifecycle.setState(State.STOPPING);
doStop();
Expand All @@ -189,5 +185,4 @@ public void shutdown() {
PlatformMetricsRegistry.stop();
LOGGER.info("Service - {} is shutdown.", getServiceName());
}

}