log4j metrics #60
Merged
log4j metrics #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laxmanchekka
requested review from
avinashkolluru and
tim-mwangi
as code owners
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #60 +/- ##
============================================
+ Coverage 69.44% 69.50% +0.05%
Complexity 106 106
============================================
Files 15 15
Lines 563 564 +1
Branches 32 32
============================================
+ Hits 391 392 +1
Misses 153 153
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tim-mwangi
approved these changes
Dec 5, 2022
surajpuvvada
reviewed
Dec 5, 2022
| new JvmThreadMetrics(DEFAULT_TAGS).bindTo(METER_REGISTRY); | ||
| new JvmMemoryMetrics(DEFAULT_TAGS).bindTo(METER_REGISTRY); | ||
| new UptimeMetrics(DEFAULT_TAGS).bindTo(METER_REGISTRY); | ||
| new Log4j2Metrics(DEFAULT_TAGS).bindTo(METER_REGISTRY); |
Contributor
There was a problem hiding this comment.
which ones are we interested in ? error rate metric ?
Contributor
Author
There was a problem hiding this comment.
want to monitor and add alert on overall log volume which includes all levels (debug, info, warn, error, fatal).
we can have a different alert at error/warn rate as well.
surajpuvvada
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for log4j metrics
Testing
Local Testing.
Checklist:
Documentation
NA.