Skip to content

Conversation

@laxmanchekka
Copy link
Contributor

Description

Added codestyle plugin and spotless fixes.

Testing

Verified the build.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

NA.

@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #64 (515c274) into main (b102518) will increase coverage by 1.34%.
The diff coverage is 77.96%.

@@             Coverage Diff              @@
##               main      #64      +/-   ##
============================================
+ Coverage     69.23%   70.57%   +1.34%     
  Complexity      106      106              
============================================
  Files            15       15              
  Lines           559      588      +29     
  Branches         32       32              
============================================
+ Hits            387      415      +28     
- Misses          153      154       +1     
  Partials         19       19              
Flag Coverage Δ
unit 70.57% <77.96%> (+1.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../core/serviceframework/PlatformServiceFactory.java 0.00% <0.00%> (ø)
...core/serviceframework/PlatformServiceLauncher.java 0.00% <0.00%> (ø)
...ramework/background/PlatformBackgroundService.java 61.11% <ø> (ø)
...eframework/config/dynamic/DynamicConfigClient.java 0.00% <ø> (ø)
...framework/service/servlets/HealthCheckServlet.java 30.00% <ø> (ø)
...amework/service/servlets/JVMDiagnosticServlet.java 86.20% <50.00%> (+1.46%) ⬆️
...ertrace/core/serviceframework/PlatformService.java 69.89% <66.66%> (-0.11%) ⬇️
...viceframework/metrics/PlatformMetricsRegistry.java 81.87% <86.95%> (-0.32%) ⬇️
.../metrics/registry/PrometheusPushMeterRegistry.java 88.23% <90.00%> (+3.38%) ⬆️
...k/metrics/config/PrometheusPushRegistryConfig.java 100.00% <100.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

* ---- /path/to/configs/[service]/[cluster]/application.conf
* ---- /path/to/configs/[service]/[cluster]/[pod]/application.conf
* ---- /path/to/configs/[service]/[cluster]/[pod]/[container]/application.conf
* <p>e.g. The override convention for application.conf is: ---- /path/to/configs/application.conf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof. This has been messed up.

@laxmanchekka laxmanchekka merged commit f11481a into main Jan 19, 2023
@laxmanchekka laxmanchekka deleted the code-style branch January 19, 2023 08:03
@github-actions
Copy link

Unit Test Results

  9 files  ±0    9 suites  ±0   9s ⏱️ -1s
31 tests ±0  31 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f11481a. ± Comparison against base commit b102518.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants