Skip to content

feat: add registry-level client interceptor support for http container #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2023
Merged

feat: add registry-level client interceptor support for http container #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions platform-http-service-framework/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ dependencies {
api("com.google.inject:guice:5.1.0")
api(project(":service-framework-spi"))

implementation(project(":platform-metrics"))
implementation("org.slf4j:slf4j-api:1.7.36")
implementation("com.google.inject.extensions:guice-servlet:5.1.0")
implementation("com.google.guava:guava:31.1-jre")
Expand Down
12 changes: 11 additions & 1 deletion ...ava/org/hypertrace/core/serviceframework/http/StandAloneHttpPlatformServiceContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,31 @@
import static io.grpc.Deadline.after;
import static java.util.concurrent.TimeUnit.SECONDS;

import io.micrometer.core.instrument.binder.grpc.MetricCollectingClientInterceptor;
import java.util.List;
import java.util.stream.Collectors;
import lombok.extern.slf4j.Slf4j;
import org.hypertrace.core.grpcutils.client.GrpcChannelRegistry;
import org.hypertrace.core.grpcutils.client.GrpcRegistryConfig;
import org.hypertrace.core.serviceframework.PlatformService;
import org.hypertrace.core.serviceframework.config.ConfigClient;
import org.hypertrace.core.serviceframework.http.jetty.JettyHttpServerBuilder;
import org.hypertrace.core.serviceframework.metrics.PlatformMetricsRegistry;

@Slf4j
public abstract class StandAloneHttpPlatformServiceContainer extends PlatformService {
private HttpContainer container;
private final GrpcChannelRegistry grpcChannelRegistry = new GrpcChannelRegistry();
private final GrpcChannelRegistry grpcChannelRegistry;

public StandAloneHttpPlatformServiceContainer(ConfigClient config) {
super(config);
grpcChannelRegistry =
new GrpcChannelRegistry(
GrpcRegistryConfig.builder()
.defaultInterceptor(
new MetricCollectingClientInterceptor(
PlatformMetricsRegistry.getMeterRegistry()))
.build());
}

protected abstract List<HttpHandlerFactory> getHandlerFactories();
Expand Down