Skip to content

Conversation

@aaron-steinfeld
Copy link
Contributor

Description

Ref: hypertrace/java-grpc-utils#53 (also waiting on that to resolve version refs)

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner December 1, 2023 23:24
@github-actions
Copy link

github-actions bot commented Dec 1, 2023

Test Results

31 tests  ±0   31 ✔️ ±0   7s ⏱️ -3s
  9 suites ±0     0 💤 ±0 
  9 files   ±0     0 ±0 

Results for commit 78f635d. ± Comparison against base commit 2b98d27.

♻️ This comment has been updated with latest results.

api("io.grpc:grpc-api")
api("io.grpc:grpc-services")
api("org.hypertrace.core.grpcutils:grpc-client-utils:0.12.6")
api("org.hypertrace.core.grpcutils:grpc-client-utils:0.12.7-SNAPSHOT")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snapshot?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was waiting on the earlier PR

tim-mwangi
tim-mwangi previously approved these changes Dec 4, 2023
@skjindal93 skjindal93 requested a review from tim-mwangi December 4, 2023 12:17
@codecov
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b98d27) 70.21% compared to head (78f635d) 70.21%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #82   +/-   ##
=========================================
  Coverage     70.21%   70.21%           
  Complexity      106      106           
=========================================
  Files            15       15           
  Lines           591      591           
  Branches         32       32           
=========================================
  Hits            415      415           
  Misses          157      157           
  Partials         19       19           
Flag Coverage Δ
unit 70.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aaron-steinfeld aaron-steinfeld requested a review from a team December 4, 2023 13:29
@aaron-steinfeld aaron-steinfeld merged commit d6508f6 into main Dec 4, 2023
@aaron-steinfeld aaron-steinfeld deleted the more-rapid-rst branch December 4, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants