Cache max size metric #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
============================================
- Coverage 70.21% 68.48% -1.74%
Complexity 106 106
============================================
Files 15 15
Lines 591 606 +15
Branches 32 32
============================================
Hits 415 415
- Misses 157 172 +15
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
avinashkolluru
approved these changes
Jan 31, 2024
| CacheBuilder<Object, Object> guavaCacheBuilder, | ||
| CacheLoader<? super K, V> loader, | ||
| Map<String, String> tags) { | ||
| reportCacheMaxSize(cacheName, guavaCacheBuilder); |
Contributor
There was a problem hiding this comment.
should we be propagating the tags to cache max size metric as well?
Contributor
There was a problem hiding this comment.
Discussed offline. will have an immediate followup PR to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.