Skip to content

fix: log4j impl should not be provided by metrics #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2024
Merged

fix: log4j impl should not be provided by metrics #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f303e36
fix: log4j impl should not be provided by metrics
aaron-steinfeld Apr 19, 2024
276f2e8
chore: try updating uploader
aaron-steinfeld Apr 19, 2024
02db985
ci: use codecov token
aaron-steinfeld Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,12 @@ jobs:
args: build jacocoTestReport

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
with:
name: unit test reports
fail_ci_if_error: true
flags: unit
token: ${{ secrets.CODECOV_TOKEN }}

- name: copy test reports
uses: hypertrace/github-actions/gradle@main
Expand Down
2 changes: 1 addition & 1 deletion platform-metrics/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ dependencies {

implementation("io.github.mweirauch:micrometer-jvm-extras:0.2.2")
implementation("org.slf4j:slf4j-api:1.7.36")
implementation("org.apache.logging.log4j:log4j-slf4j-impl:2.19.0")
implementation("io.dropwizard.metrics:metrics-jvm:4.2.16")
implementation("io.prometheus:simpleclient_dropwizard:0.12.0")
implementation("io.prometheus:simpleclient_servlet:0.12.0")
Expand All @@ -32,4 +31,5 @@ dependencies {
testImplementation("org.junit.jupiter:junit-jupiter:5.9.0")
testImplementation("org.mockito:mockito-core:4.8.0")
testImplementation("com.github.ben-manes.caffeine:caffeine:3.1.8")
testRuntimeOnly("org.apache.logging.log4j:log4j-slf4j-impl:2.19.0")
}