fix: update default value for CONTEXT_STACK_KEY to null #269
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to change the default value for CONTEXT_STACK_KEY from an empty array to null in the Sentry service provider's coroutine initialization logic. However, this change introduces a critical bug that will cause type errors when Hub::pushScope() is called.
Key Changes
- Modified the default initialization value for
Hub::CONTEXT_STACK_KEYfrom[]tonullin the coroutine context setup
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Coroutine::afterCreated(function () { | ||
| $keys = [ | ||
| Hub::CONTEXT_STACK_KEY => [], | ||
| Hub::CONTEXT_STACK_KEY => null, |
There was a problem hiding this comment.
Changing the default value from [] to null will cause a TypeError in Hub::pushScope().
When Context::override() is called in Hub::pushScope() (line 61), it passes the current context value to a closure with type hint function (array $layers). If the context was initialized with null (as set by this change), the closure will receive null instead of an array, causing a type error: "Argument #1 must be of type array, null given".
The previous default value of [] ensured type compatibility with the closure in pushScope(). Consider reverting this change or update the closure in Hub::pushScope() to handle nullable arrays.
| Hub::CONTEXT_STACK_KEY => null, | |
| Hub::CONTEXT_STACK_KEY => [], |
2 participants
No description provided.