Request example for Create user on PHP: setDateOfBirth method is not correct #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aseveryn-hw
reviewed
Nov 28, 2019
| public function setDateOfBirth($dateOfBirth = null) | ||
| { | ||
| $stringToDate = $dateOfBirth === null ? null : new \DateTime($dateOfBirth); | ||
| $this->dateOfBirth = $stringToDate == null ? null : $stringToDate->format('Y-m-d'); |
Contributor
There was a problem hiding this comment.
As this date manipulation is done in several places, I suggest to make a common util method and use it in different places
Contributor
Author
There was a problem hiding this comment.
Done, thank you.
iganzina-epam
approved these changes
Nov 28, 2019
aseveryn-hw
reviewed
Nov 28, 2019
|
|
||
| class StringToDataConverter | ||
| { | ||
| static function convertStringToDate($string, $format) |
Contributor
There was a problem hiding this comment.
Can we cover this method with tests?
gmeyer-hw
suggested changes
Nov 28, 2019
Contributor
gmeyer-hw
left a comment
gmeyer-hw
left a comment
There was a problem hiding this comment.
I read the requirement and I noticed the doc-portal doesn't contain valid code snippet for the Python, Java and PHP SDK. I added more info on the ticket.
igusar-epam
approved these changes
Dec 4, 2019
Contributor
Author
|
It's not necessary anymore because there is an another pr for solving this problem https://github.com/hyperwallet/program-portal/pull/215 |
dyurchenko-epam
deleted the
bugfix/HW-54154-request-example-for-create-user-on-php-setDateOfBirth-method-is-not-correct
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.site1.hyperwallet.local/browse/HW-54154