Backporting changes merged to v4, also in v3 #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey @jchanghw @Rrathinasabapath just wanted to draw attention to this one. |
# Conflicts: # tests/Hyperwallet/Tests/Util/HyperwalletEncryptionTest.php
vkorotchenko
approved these changes
Nov 20, 2020
arao6
approved these changes
Nov 20, 2020
Contributor
Author
|
Thank you! |
|
@specialtactics Thank you for your patience, we also did a release on friday. Changes should now be available in 1.6.1 |
Contributor
Author
|
No problem @vkorotchenko , and thanks we're already using this new tag! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I am back-porting these merged PRs (which were merged into v4), so that they can also be in v3 api sdk version.
https://github.com/hyperwallet/php-sdk/pull/44/files
https://github.com/hyperwallet/php-sdk/pull/23/files
Could you please accept and tag this in v1 of this SDK?
Thanks!