bug: still getting "Too many open files" OS error

[nick1udwig]

Describe the bug
Can sometimes get an OS error from linux: "Too many open files"

https://discord.com/channels/1186394868336038080/1186684706700410962/1280889566110289922

To Reproduce
Not sure

Expected behavior
Don't open too many files

[nick1udwig]

https://discord.com/channels/1186394868336038080/1186684706700410962/1281722686787289178

[barraguda]

to reproduce one can write a once running process something like this

I hit the limit at ~200 files. Working on a forced cleanup if MAX_FILES are reached rather than just running one at an interval.

fn init(our: Address) {
    println!("begin");

    let drive = vfs::create_drive(our.package_id(), "hello", None).unwrap();
    let mut open_files: HashMap<String, File> = HashMap::new();

    let amount_files = 500;
    for i in 0..amount_files {
        let file_name = format!("{}/test_{}.txt", &drive, i);
        match vfs::open_file(&file_name, true, None) {
            Ok(mut file) => {
                match file.write_all("hellO world".as_bytes()) {
                    Ok(_) => {}
                    Err(e) => println!("got error while writing to file {}: {e:?}", file_name),
                }
                open_files.insert(file_name.clone(), file);
            }
            Err(e) => println!("got error while opening file: {e:?}"),
        }
    }
    println!("wrote {} files", amount_files);

    for (file_name, file) in open_files.iter_mut() {
        match file.read_to_string() {
            Ok(s) => println!("read: {s}, from {file_name}"),
            Err(e) => println!("got error while reading file {}: {e:?}", file_name),
        }
        match file.write_all("hellO world".as_bytes()) {
            Ok(_) => {}
            Err(e) => println!("got error while writing to file {}: {e:?}", file_name),
        }
    }

    println!("done.");
}