Skip to content

new eth #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Feb 15, 2024
Merged

new eth #222

merged 30 commits into from
Feb 15, 2024

Conversation

barraguda
Copy link
Contributor

@barraguda barraguda commented Feb 1, 2024 •
edited
Loading

goals:

  • remove ethers-rs in favor of alloy-rs [x]
  • signatures, easy calls from processes (send-and-await) [x]
  • rpc passthrough [x]
  • remove ethers from src/register/client [x]

@barraguda barraguda changed the base branch from main to develop February 1, 2024 22:14
@barraguda barraguda mentioned this pull request Feb 5, 2024
Merged
Base automatically changed from develop to main February 7, 2024 15:32
@dr-frmr dr-frmr changed the base branch from main to develop February 7, 2024 15:32
@barraguda barraguda requested a review from dr-frmr February 12, 2024 20:31
dr-frmr
dr-frmr reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@dr-frmr dr-frmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good so far. I need to run locally and play around with it, but looks almost ready to merge.

barraguda
barraguda commented Feb 13, 2024
View reviewed changes
barraguda
barraguda commented Feb 13, 2024
View reviewed changes
dr-frmr
dr-frmr suggested changes Feb 15, 2024
View reviewed changes
dr-frmr
dr-frmr approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@dr-frmr dr-frmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG

@barraguda barraguda merged commit 15eb38b into develop Feb 15, 2024
@barraguda barraguda deleted the bp/new-eth branch February 15, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dr-frmr dr-frmr dr-frmr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@barraguda @dr-frmr