Da/drop #234
Merged
Da/drop #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix clone URL so it works for everyone
dr-frmr
suggested changes
Feb 8, 2024
Comment on lines
+386
to
+388
| // first check to make sure the script is actually a script | ||
| let Ok(_) = get_entry(&process) else { | ||
| return Err(anyhow!("terminal: process {} not found", process)); |
There was a problem hiding this comment.
again, is this check necessary? it's not crazy to have aliases be settable for nonexistent scripts and show a descriptive error when the alias gets used
There was a problem hiding this comment.
I like having the extra check. It saves an extra step from 1. save alias, 2. try using alias and it fails, 3. reset alias to just 1. get an error for failed alias 2. reset alias
Plus this check adds basically no time
added 8 commits
February 8, 2024 14:44
dr-frmr
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: can't merge before hyperware-ai/process_lib#50 (need to update
Cargo.tomls to reflect latest version)drop_capabilitiesadded tostandard_host.rsOnExit::RequestsaliasNote that while
DropCapsisn't used in the final version of this PR, it was tested on an earlier commit