Skip to content

Da/timer #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 12, 2024
Merged

Da/timer #247

merged 2 commits into from
Feb 12, 2024

Conversation

tadad
Copy link
Contributor

@tadad tadad commented Feb 12, 2024 •
edited
Loading

Quick PR to formalize the timer api

Should be merged with corresponding process_lib changes: hyperware-ai/process_lib#54

@tadad tadad changed the base branch from main to develop February 12, 2024 17:41
@tadad tadad requested a review from dr-frmr February 12, 2024 17:46
dr-frmr
dr-frmr approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@dr-frmr dr-frmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this. Do you feel like adding a CancelTimer action? Seems like that should be possible.

@tadad tadad merged commit 5f71e26 into develop Feb 12, 2024
@tadad tadad deleted the da/timer branch February 12, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dr-frmr dr-frmr dr-frmr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tadad @dr-frmr